Resize sidebar icons #1217
Merged
Resize sidebar icons #1217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
91volt
approved these changes
Jul 19, 2022
per1234
added
type: enhancement
|
Hi, Internet people say there are better ways to load and use a custom font in the web app than this, as it takes time, causes performance problems, and is noticeable. font-load.mp4
Another thing I need help understanding is how the new font relates to the sidebar icon size in this PR. I am referring to this change: https://github.com/arduino/arduino-ide/pull/1217/files#diff-30d42744c8ff8ad2ab080f1eae83f81a355d573dcc90b6d1c351b68be42321bdR1-R4 How do you FE guys do in other apps? Thanks! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The icons in the sidebar must be resized.
Change description
Decrease the icons size.
Reviewer checklist